Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add location based deleted Web Apps #5905

Merged
merged 7 commits into from
May 10, 2019
Merged

Add location based deleted Web Apps #5905

merged 7 commits into from
May 10, 2019

Conversation

naveedaz
Copy link
Contributor

@naveedaz naveedaz commented May 9, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented May 9, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Encountered a Subprocess error: (azure-sdk-for-ruby)

Command: ['/usr/local/bin/autorest', '/tmp/tmp3d__uk_i/rest/specification/web/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmp6bgphpu7']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4370/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

@AutorestCI
Copy link

AutorestCI commented May 9, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4429

@naveedaz naveedaz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 9, 2019
@azuresdkci azuresdkci requested a review from amarzavery May 9, 2019 19:00
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@naveedaz
Copy link
Contributor Author

naveedaz commented May 9, 2019

Location-based DeletedSites are proxy-only resources. They only support GET. The existing top-level DeletedSites will be deprecated once the location-based DeletedSites are live.

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 9, 2019
@adxsdknet
.NET SDK Resource Provider:'WebSites'
494670f 
REST Spec PR 'Azure/azure-rest-api-specs#5905'
REST Spec PR Author 'naveedaz'
REST Spec PR Last commit
@adxsdknet
Copy link

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#6234
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@494670f

majastrz
majastrz approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 9, 2019
This was referenced May 10, 2019
Merged
Merged
@AutorestCI
Copy link

AutorestCI commented May 10, 2019 •
edited
Loading

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#2813

@AutorestCI AutorestCI mentioned this pull request May 10, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented May 10, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4773

@AutorestCI AutorestCI mentioned this pull request May 10, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented May 10, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3017

@naveedaz
Copy link
Contributor Author

@amarzavery Please review and merge this change.

@amarzavery amarzavery merged commit 3d3406f into Azure:master May 10, 2019
dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request May 14, 2019
@adxsdknet @dsgouda
.NET SDK Resource Provider:'WebSites' (#6234)
44886c9 
REST Spec PR 'Azure/azure-rest-api-specs#5905'
REST Spec PR Author 'naveedaz'
REST Spec PR Last commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarzavery amarzavery amarzavery approved these changes

@majastrz majastrz majastrz approved these changes

@ruslany ruslany Awaiting requested review from ruslany

@ravbhatnagar ravbhatnagar Awaiting requested review from ravbhatnagar

Assignees

@amarzavery amarzavery

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@naveedaz @AutorestCI @azuresdkci @adxsdknet @amarzavery @majastrz